* @copyright 2006-2012 Squiz Pty Ltd (ABN 77 084 670 600) * @license https://github.com/squizlabs/PHP_CodeSniffer/blob/master/licence.txt BSD Licence * @link http://pear.php.net/package/PHP_CodeSniffer */ /** * PEAR_Sniffs_Functions_FunctionDeclarationSniff. * * Ensure single and multi-line function declarations are defined correctly. * * @category PHP * @package PHP_CodeSniffer * @author Greg Sherwood * @copyright 2006-2012 Squiz Pty Ltd (ABN 77 084 670 600) * @license https://github.com/squizlabs/PHP_CodeSniffer/blob/master/licence.txt BSD Licence * @version Release: 1.5.1 * @link http://pear.php.net/package/PHP_CodeSniffer */ class PhOSCo_Sniffs_Functions_FunctionDeclarationSniff implements PHP_CodeSniffer_Sniff { /** * The number of spaces code should be indented. * * @var int */ public $indent = 4; /** * Returns an array of tokens this test wants to listen for. * * @return array */ public function register() { return array(T_FUNCTION, T_CLOSURE,); }//end register() /** * Processes this test, when one of its tokens is encountered. * * @param PHP_CodeSniffer_File $phpcsFile The file being scanned. * @param int $stackPtr The position of the current token * in the stack passed in $tokens. * * @return void */ public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr) { $tokens = $phpcsFile->getTokens(); $spaces = 0; if ($tokens[($stackPtr + 1)]['code'] === T_WHITESPACE) { $spaces = strlen($tokens[($stackPtr + 1)]['content']); } if ($spaces !== 1) { $error = 'Expected 1 space after FUNCTION keyword; %s found'; $data = array($spaces); $phpcsFile->addError($error, $stackPtr, 'SpaceAfterFunction', $data); } // Must be one space before and after USE keyword for closures. $openBracket = $tokens[$stackPtr]['parenthesis_opener']; $closeBracket = $tokens[$stackPtr]['parenthesis_closer']; if ($tokens[$stackPtr]['code'] === T_CLOSURE) { $use = $phpcsFile->findNext(T_USE, ($closeBracket + 1), $tokens[$stackPtr]['scope_opener']); if ($use !== false) { if ($tokens[($use + 1)]['code'] !== T_WHITESPACE) { $length = 0; } else if ($tokens[($use + 1)]['content'] === "\t") { $length = '\t'; } else { $length = strlen($tokens[($use + 1)]['content']); } if ($length !== 1) { $error = 'Expected 1 space after USE keyword; found %s'; $data = array($length); $phpcsFile->addError($error, $use, 'SpaceAfterUse', $data); } if ($tokens[($use - 1)]['code'] !== T_WHITESPACE) { $length = 0; } else if ($tokens[($use - 1)]['content'] === "\t") { $length = '\t'; } else { $length = strlen($tokens[($use - 1)]['content']); } if ($length !== 1) { $error = 'Expected 1 space before USE keyword; found %s'; $data = array($length); $phpcsFile->addError($error, $use, 'SpaceBeforeUse', $data); } }//end if }//end if // Check if this is a single line or multi-line declaration. $singleLine = true; if ($tokens[$openBracket]['line'] === $tokens[$closeBracket]['line']) { // Closures may use the USE keyword and so be multi-line in this way. if ($tokens[$stackPtr]['code'] === T_CLOSURE) { if ($use !== false) { // If the opening and closing parenthesis of the use statement // are also on the same line, this is a single line declaration. $open = $phpcsFile->findNext(T_OPEN_PARENTHESIS, ($use + 1)); $close = $tokens[$open]['parenthesis_closer']; if ($tokens[$open]['line'] !== $tokens[$close]['line']) { $singleLine = false; } } } } else { $singleLine = false; } if ($singleLine === true) { $this->processSingleLineDeclaration($phpcsFile, $stackPtr, $tokens); } else { $this->processMultiLineDeclaration($phpcsFile, $stackPtr, $tokens); } }//end process() /** * Processes single-line declarations. * * Just uses the Generic BSD-Allman brace sniff. * * @param PHP_CodeSniffer_File $phpcsFile The file being scanned. * @param int $stackPtr The position of the current token * in the stack passed in $tokens. * @param array $tokens The stack of tokens that make up * the file. * * @return void */ public function processSingleLineDeclaration(PHP_CodeSniffer_File $phpcsFile, $stackPtr, $tokens) { if (class_exists('Generic_Sniffs_Functions_OpeningFunctionBraceKernighanRitchieSniff', true) === false) { throw new PHP_CodeSniffer_Exception( 'Class Generic_Sniffs_Functions_OpeningFunctionBraceKernighanRitchieSniff not found'); } $sniff = new Generic_Sniffs_Functions_OpeningFunctionBraceKernighanRitchieSniff(); $sniff->process($phpcsFile, $stackPtr); }//end processSingleLineDeclaration() /** * Processes mutli-line declarations. * * @param PHP_CodeSniffer_File $phpcsFile The file being scanned. * @param int $stackPtr The position of the current token * in the stack passed in $tokens. * @param array $tokens The stack of tokens that make up * the file. * * @return void */ public function processMultiLineDeclaration(PHP_CodeSniffer_File $phpcsFile, $stackPtr, $tokens) { // We need to work out how far indented the function // declaration itself is, so we can work out how far to // indent parameters. $functionIndent = 0; for ($i = ($stackPtr - 1); $i >= 0; $i--) { if ($tokens[$i]['line'] !== $tokens[$stackPtr]['line']) { $i++; break; } } if ($tokens[$i]['code'] === T_WHITESPACE) { $functionIndent = strlen($tokens[$i]['content']); } // The closing parenthesis must be on a new line, even // when checking abstract function definitions. $closeBracket = $tokens[$stackPtr]['parenthesis_closer']; $prev = $phpcsFile->findPrevious(T_WHITESPACE, ($closeBracket - 1), null, true); if ($tokens[$closeBracket]['line'] !== $tokens[$tokens[$closeBracket]['parenthesis_opener']]['line']) { if ($tokens[$prev]['line'] === $tokens[$closeBracket]['line']) { $error = 'The closing parenthesis of a multi-line function declaration must be on a new line'; $phpcsFile->addError($error, $closeBracket, 'CloseBracketLine'); } } // If this is a closure and is using a USE statement, the closing // parenthesis we need to look at from now on is the closing parenthesis // of the USE statement. if ($tokens[$stackPtr]['code'] === T_CLOSURE) { $use = $phpcsFile->findNext(T_USE, ($closeBracket + 1), $tokens[$stackPtr]['scope_opener']); if ($use !== false) { $open = $phpcsFile->findNext(T_OPEN_PARENTHESIS, ($use + 1)); $closeBracket = $tokens[$open]['parenthesis_closer']; $prev = $phpcsFile->findPrevious(T_WHITESPACE, ($closeBracket - 1), null, true); if ($tokens[$closeBracket]['line'] !== $tokens[$tokens[$closeBracket]['parenthesis_opener']]['line']) { if ($tokens[$prev]['line'] === $tokens[$closeBracket]['line']) { $error = 'The closing parenthesis of a multi-line use declaration must be on a new line'; $phpcsFile->addError($error, $closeBracket, 'CloseBracketLine'); } } }//end if }//end if // Each line between the parenthesis should be indented 4 spaces. $openBracket = $tokens[$stackPtr]['parenthesis_opener']; $lastLine = $tokens[$openBracket]['line']; for ($i = ($openBracket + 1); $i < $closeBracket; $i++) { if ($tokens[$i]['line'] !== $lastLine) { if ($i === $tokens[$stackPtr]['parenthesis_closer'] || ($tokens[$i]['code'] === T_WHITESPACE && (($i + 1) === $closeBracket || ($i + 1) === $tokens[$stackPtr]['parenthesis_closer']))) { // Closing braces need to be indented to the same level // as the function. $expectedIndent = $functionIndent; } else { $expectedIndent = ($functionIndent + $this->indent); } // We changed lines, so this should be a whitespace indent token. if ($tokens[$i]['code'] !== T_WHITESPACE) { $foundIndent = 0; } else { $foundIndent = strlen($tokens[$i]['content']); } if ($expectedIndent !== $foundIndent) { $error = 'Multi-line function declaration not indented correctly; expected %s spaces but found %s'; $data = array($expectedIndent, $foundIndent,); $phpcsFile->addError($error, $i, 'Indent', $data); } $lastLine = $tokens[$i]['line']; }//end if if ($tokens[$i]['code'] === T_ARRAY) { // Skip arrays as they have their own indentation rules. $i = $tokens[$i]['parenthesis_closer']; $lastLine = $tokens[$i]['line']; continue; } }//end for if (isset($tokens[$stackPtr]['scope_opener']) === true) { // The openning brace needs to be one space away // from the closing parenthesis. $next = $tokens[($closeBracket + 1)]; if ($next['code'] !== T_WHITESPACE) { $length = 0; } else if ($next['content'] === $phpcsFile->eolChar) { $length = -1; } else { $length = strlen($next['content']); } if ($length !== 1) { $data = array($length); $code = 'SpaceBeforeOpenBrace'; $error = 'There must be a single space between the closing parenthesis and the opening brace of a multi-line function declaration; found '; if ($length === -1) { $error .= 'newline'; $code = 'NewlineBeforeOpenBrace'; } else { $error .= '%s spaces'; } $phpcsFile->addError($error, ($closeBracket + 1), $code, $data); return; } // And just in case they do something funny before the brace... $next = $phpcsFile->findNext(T_WHITESPACE, ($closeBracket + 1), null, true); if ($next !== false && $tokens[$next]['code'] !== T_OPEN_CURLY_BRACKET) { $error = 'There must be a single space between the closing parenthesis and the opening brace of a multi-line function declaration'; $phpcsFile->addError($error, $next, 'NoSpaceBeforeOpenBrace'); } }//end if }//end processMultiLineDeclaration() }//end class ?>